Issue #34 - add numberposts range control

bobbingwide · Feb 2, 2020 · 0d86678 · 0d86678
1 parent defa815
commit 0d86678
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 24 deletions.
diff --git a/blocks/oik-content/attributes.js b/blocks/oik-content/attributes.js
@@ -5,12 +5,7 @@ const shortcode_attributes =
             default: '',
         },
 
-        content: {
-            type: 'string',
-            default: '',
-        },
-
-        parameters: {
+       parameters: {
             type: 'string',
             default: '',
         },
@@ -25,8 +20,8 @@ const shortcode_attributes =
             default: '.',
         },
 
-        number_posts: {
-            type: 'string',
+        numberposts: {
+            type: 'integer',
             default: 10,
         }
 

diff --git a/blocks/oik-content/edit.js b/blocks/oik-content/edit.js
@@ -28,6 +28,7 @@ const {
     TextControl,
     TextareaControl,
     SelectControl,
+    RangeControl,
 } = wp.components;
 const Fragment = wp.element.Fragment;
 import { map, partial, has } from 'lodash';
@@ -37,6 +38,7 @@ import { map, partial, has } from 'lodash';
 
 import {bw_shortcodes, getAttributes} from "./bw_shortcodes";
 import {PostTypes} from "./post_type";
+import{ NumberPosts } from './numberposts';
 
 const edit= withInstanceId(
     ( { attributes, setAttributes, instanceId, isSelected } ) => {
@@ -75,7 +77,7 @@ const edit= withInstanceId(
         }
 
         const onChangeNumberPosts = ( value ) => {
-            setAttributes( { number_posts: value } );
+            setAttributes( { numberposts: value } );
         }
 
 
@@ -92,20 +94,17 @@ const edit= withInstanceId(
                                        onChange={partial( onChangeAttr, 'shortcode' )}
                         />
 
-                        <PostTypes value={ attributes.post_type } onChange={onChangePostType } />
+                        <PostTypes value={ attributes.post_type } onChange={ onChangePostType } />
+                        <RangeControl label="Number posts" value={ attributes.numberposts } onChange={ onChangeNumberPosts } min={-1} max={100} />
+                        <TextControl value={ attributes.post_parent} onChange={ onChangePostParent } label="Post Parent" />
 
-                        <TextareaControl label="Parameters"
+                        <TextareaControl label="Advanced Parameters"
                                          value={ attributes.parameters }
-                                         placeholder={ __( 'Enter your shortcode parameters' ) }
+                                         placeholder={ __( 'Enter your advanced shortcode parameters' ) }
                                          onChange={onChangeParameters}
                                          rows="1"
                         />
-                        <TextareaControl label="Content"
-                                         id={ inputId }
-                                         value={ attributes.content }
-                                         placeholder={ __( 'Enter your shortcode content' ) }
-                                         onChange={onChangeContent}
-                        />
+
 
 
 

diff --git a/blocks/oik-content/number_posts.js b/blocks/oik-content/number_posts.js
diff --git a/blocks/oik-content/numberposts.js b/blocks/oik-content/numberposts.js
@@ -0,0 +1,40 @@
+/**
+ * Implements the NumberPosts control
+ *
+ * Usage:
+ * <NumberPosts value={ attributes.numberposts } onChange={onChangeNumberPosts} />
+ *
+ * @copyright (C) Copyright Bobbing Wide 2020
+ * @author Herb Miller @bobbingwide
+ */
+const { RangeControl} = wp.components;
+const { Component } = wp.element;
+
+export class NumberPosts extends Component {
+    constructor() {
+        super( ...arguments );
+        console.log( this );
+    }
+
+    render( ) {
+
+        return(
+            <RangeControl
+                label="Number Posts"
+                value={ this.props.numberposts }
+                onChange={ this.props.onChange }
+                min={ 1 }
+                max={ 100 }
+                allowRest={true}
+            />
+        );
+    }
+}
+
+
+
+
+
+
+
+
diff --git a/oik-blocks.php b/oik-blocks.php
@@ -638,11 +638,11 @@ function oik_blocks_register_dynamic_blocks() {
 					//, 'script'        => null
 					, 'attributes'    =>
 						[ 'shortcode' => [ 'type'=>'string' ]
-						,'content' => [ 'type' => 'string ']
+						, 'content' => [ 'type' => 'string ']
 						, 'parameters' => [ 'type' => 'string']
 						, 'post_type' => ['type' => 'string']
 						, 'post_parent' => ['type' => 'string']
-						, 'number_posts' => ['type' => 'string']
+						, 'numberposts' => ['type' => 'integer']
 
 						]
 				] );