Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dynamic block to replace the [bw_contact_form] shortcode #7

Closed
bobbingwide opened this issue Feb 28, 2018 · 4 comments
Closed
Assignees

Comments

@bobbingwide
Copy link
Owner

The [bw_contact_form] shortcode displays a simple HTML form.
We would like to be able to use the existing logic in a dynamic block.

Requirement

  • Develop a new block called Contact form
  • Support the attributes that may be passed to the existing [bw_contact_form] shortcode

Proposed solution

  • Implement as a Dynamic block.
@bobbingwide
Copy link
Owner Author

To test #8 we'll change the registration of the Contact form block so that Gutenberg enqueues the styles.
We'll then have to investigate how to change the build to produce multiple scripts and see how that affects the overall behaviour of the site.

@bobbingwide
Copy link
Owner Author

Changing the edit: method to return using parentheses rather than square brackets seems to resolve the annoying react message about duplicate keys. It'd be nice to know why... but I'll check in this version anyway.

@bobbingwide
Copy link
Owner Author

The Contact form already works with Gutenberg v4.0.0 but the following changes could be made anyway.

@bobbingwide bobbingwide transferred this issue from bobbingwide/oik-block Nov 21, 2018
@bobbingwide
Copy link
Owner Author

The Contact form block is now delivered in oik. See bobbingwide/oik#138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant