-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blocks to work with Gutenberg v5.1.1 and/or WordPress 5.0.3 / 5.1 #15
Comments
The code should work with Gutenberg v.4.1.0 when it's released. Currently v4.1.0-rc.2 |
It would be nice if the JavaScript ( .js ) code was documented according to WordPress's JavaScript Documentation Standards. https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ e.g. For the start of each file
Not sure if it's necessary to use @url, @link or others. What about @Package? |
oik-block is not working at all on WordPress 5.0-beta5 on my new laptop with Edge.
It was. Workaround was to install oik-bwtrace. It didn't need activating. |
With WordPress 5.0-beta5 but NOT Gutenberg the Github Issue block produces a Console log message and none of the oik-block blocks load.
I mentioned this on Slack and was told I needed to add dependencies on the script registration. I needed to add wp.components and wp.editor to make it work in native WordPress 5.0-beta5. |
It turns out that the real problem was that my code was registering the editor blocks on the front end. This also caused a problem with Autoptimize. The fix is applied in https://github.com/bobbingwide/oik-blocks |
When responding to |
I noticed a major problem when WordPress SEO was activated.
The logic should not fail in this instance. Either we update the check or simply remove the ( debugging ) call to the missing function |
Gutenberg 4.8.0 was released on 7th/8th Jan 2019. WordPress 5.0.3 on 9th Jan. |
It's about time we switched from alpha versions to proper semantic numbering. The next version, delivering the Block info block will be 0.2.0. |
The table should be updated to reflect the status for all the blocks under development for oik-blocks and their operational status with Gutenberg 5.1.1 and WordPress 5.1 |
Closing this as I'm now retesting the most recent version of the blocks with WordPress 5.9 and/or Gutenberg 12.3.2 |
It's been some time since I built the code with Gutenberg. It was last built with 2.9.2. There have been many changes since, with code being deprecated and so on.
Some of the blocks no longer work. They need fixing. I'll use the original issues for each block, adding a comment on each on that doesn't yet work.
Some of the blocks may be rewritten to reflect a better way of implementing the code in the first place.
Note: Issue references needed updating after the issues were transferred from oik-block to oik-blocks. Labels also need re-creating.
The text was updated successfully, but these errors were encountered: