Skip to content

Commit

Permalink
Updates based on API review feedback (Killeroo#49)
Browse files Browse the repository at this point in the history
* Updates based on API review feedback

* Fixed PR feedback

* Fixing samples
  • Loading branch information
jasonsandlin authored Sep 13, 2017
1 parent 9a9f9a3 commit 4e4c372
Show file tree
Hide file tree
Showing 48 changed files with 1,207 additions and 1,163 deletions.
7 changes: 5 additions & 2 deletions Build/libHttpClient.140.UWP.C/libHttpClient.140.UWP.C.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch_common.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\httpcall.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Logger\trace_internal.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\types.h" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\Win\utils_win.cpp" />
Expand All @@ -140,7 +143,7 @@
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\settings_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.cpp" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp">
Expand Down Expand Up @@ -51,6 +51,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
Expand All @@ -72,7 +81,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h">
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h">
Expand Down
7 changes: 5 additions & 2 deletions Build/libHttpClient.141.UWP.C/libHttpClient.141.UWP.C.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch_common.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\httpcall.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Logger\trace_internal.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\types.h" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\Win\utils_win.cpp" />
Expand All @@ -140,7 +143,7 @@
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\settings_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.cpp" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp">
Expand Down Expand Up @@ -51,6 +51,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
Expand All @@ -72,7 +81,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h">
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch_common.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\httpcall.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Logger\trace_internal.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\types.h" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\Win\utils_win.cpp" />
Expand All @@ -130,7 +133,7 @@
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\settings_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.cpp" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp">
Expand Down Expand Up @@ -51,6 +51,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
Expand All @@ -72,7 +81,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h">
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch_common.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\httpcall.h" />
Expand All @@ -121,6 +121,9 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Tests\UnitTests\Support\TAEF\UnitTestIncludes_TAEF.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Tests\UnitTests\Support\UnitTestIncludes.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\types.h" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\global_publics.cpp" />
Expand All @@ -131,7 +134,7 @@
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\settings_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.cpp" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp">
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp">
<Filter>C++ Source\Common</Filter>
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp">
Expand Down Expand Up @@ -66,6 +66,15 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h">
<Filter>C++ Public Includes</Filter>
</ClInclude>
Expand All @@ -87,7 +96,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h">
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h">
<Filter>C++ Source\Common</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\pch_common.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\httpcall.h" />
Expand All @@ -197,6 +197,9 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Tests\UnitTests\Support\TE\UnitTestIncludes_TE.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Tests\UnitTests\Support\UnitTestIncludes.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpClient.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\httpProvider.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\mock.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\task.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\trace.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\Include\httpClient\types.h" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\global_publics.cpp" />
Expand All @@ -207,7 +210,7 @@
</ClCompile>
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\settings_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\singleton.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\taskImpl.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\task_publics.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\Common\utils.cpp" />
<ClCompile Include="$(MSBuildThisFileDirectory)..\..\Source\HTTP\Mock\http_mock.cpp" />
Expand Down
Loading

0 comments on commit 4e4c372

Please sign in to comment.