Adding JSON export feature #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfluxDB was returning erros. So I adapted the way of building the query.
cottiAC
reviewed
Apr 6, 2022
| # Access at http://localhost:8080 or http://[serverip]:8080 | ||
| - name: jsonserver | ||
| enabled: True # [Optional] Default is False | ||
| # port: 8082 # [Optional] Default is 8080 |
There was a problem hiding this comment.
copy&paste error. Default Port is not 8080
Change default setting to off.
Keep 'exports' independent to main file.
This reverts commit 32a2792.
Revert unneeded changes in main file, keeping those separate to export files.
Fix merge conflicts
bohdan-s
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently parsing webserver output for other services. That is bad style, why I wrote an JSON export.
How does it work:
A JSON dump to text is exported via an http webserver.
The dump consists of
registers, inverter_config andclient_config. The registers part is ordered by addresses, which I think is good first approach.In order to have unique addresses for all (virtual/custom/calculated) registers, I introduced a so called virtual register
vrxxxxfor the calculated registers. ThereforegetRegisterAddress()has been enhanced.Future possible enhancement based on feedback:
As we have different addresses depending on the inverter's type for the same kind of value, changing to dict based on named keys might be also a good approach, giving a more static interface independent of the inverter type.
A next optional step could be to integrate it as a feature into the webserver export, e.g. using
localhost:8080/apior./json