Skip to content

Commit

Permalink
Added tests and middleware, and improved documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
channelcat committed Oct 14, 2016
1 parent 8b1b69e commit a74ab9b
Show file tree
Hide file tree
Showing 20 changed files with 589 additions and 44 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
settings.py
*.pyc
.idea/*
.cache/*
21 changes: 21 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) [year] [fullname]

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
27 changes: 21 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ On top of being flask-like, sanic supports async request handlers. This means y

All tests were run on a AWS medium instance running ubuntu, using 1 process. Each script delivered a small JSON response and was tested with wrk using 100 connections. Pypy was tested for falcon and flask, but did not speed up requests.

| Server | Requests/sec | Avg Latency |
| ---------------------------- | ------------:| -----------:|
| Sanic (Python 3.5 + uvloop) | 29,128 | 3.40ms |
| Falcon (gunicorn + meinheld) | 18,972 | 5.27ms |
| Flask (gunicorn + meinheld) | 4,988 | 20.08ms |
| Aiohttp (Python 3.5) | 2,187 | 56.60ms |
| Server | Implementation | Requests/sec | Avg Latency |
| ------- | ------------------- | ------------:| -----------:|
| Sanic | Python 3.5 + uvloop | 29,128 | 3.40ms |
| Falcon | gunicorn + meinheld | 18,972 | 5.27ms |
| Flask | gunicorn + meinheld | 4,988 | 20.08ms |
| Aiohttp | Python 3.5 | 2,187 | 56.60ms |

## Hello World

Expand All @@ -33,6 +33,21 @@ app.run(host="0.0.0.0", port=8000)
## Installation
* `python -m pip install git+https://github.com/channelcat/sanic/`

## Documentation
* [Getting started](docs/getting_started.md)
* [Routing](docs/routing.md)
* [Middleware](docs/routing.md)
* [Request Data](docs/request_data.md)
* [Exceptions](docs/exceptions.md)
* [License](LICENSE)

## TODO:
* Streamed file processing
* File output
* Examples of integrations with 3rd-party modules
* RESTful router
* Blueprints?

## Final Thoughts:

▄▄▄▄▄
Expand Down
14 changes: 14 additions & 0 deletions docs/contributing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
==========================
How to contribute to Sanic
==========================

Thank you for your interest!

Running tests
---------------------
* `python -m pip install pytest`
* `python -m pytest tests`

Caution
=======
One of the main goals of Sanic is speed. Code that lowers the performance of Sanic without significant gains in usability, security, or features may not be merged.
Empty file added docs/exceptions.md
Empty file.
Empty file added docs/getting_started.md
Empty file.
Empty file added docs/request_data.md
Empty file.
Empty file added docs/routing.md
Empty file.
2 changes: 2 additions & 0 deletions pytest.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[pytest]
rootdir = /vagrant/Github/sanic
4 changes: 4 additions & 0 deletions sanic/middleware.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Middleware:
def __init__(self, process_request=None, process_response=None):
self.process_request = process_request
self.process_response = process_response
74 changes: 69 additions & 5 deletions sanic/request.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
from cgi import parse_header
from collections import namedtuple
from httptools import parse_url
from urllib.parse import parse_qs
from ujson import loads as json_loads

from .log import log

class RequestParameters(dict):
"""
Hosts a dict with lists as values where get returns the first
Expand All @@ -20,7 +24,7 @@ class Request:
__slots__ = (
'url', 'headers', 'version', 'method',
'query_string', 'body',
'parsed_json', 'parsed_args', 'parsed_form',
'parsed_json', 'parsed_args', 'parsed_form', 'parsed_files',
)

def __init__(self, url_bytes, headers, version, method):
Expand All @@ -36,6 +40,7 @@ def __init__(self, url_bytes, headers, version, method):
self.body = None
self.parsed_json = None
self.parsed_form = None
self.parsed_files = None
self.parsed_args = None

@property
Expand All @@ -50,17 +55,30 @@ def json(self):

@property
def form(self):
if not self.parsed_form:
content_type = self.headers.get('Content-Type')
if self.parsed_form is None:
self.parsed_form = {}
self.parsed_files = {}
content_type, parameters = parse_header(self.headers.get('Content-Type'))
try:
# TODO: form-data
if content_type is None or content_type == 'application/x-www-form-urlencoded':
self.parsed_form = RequestParameters(parse_qs(self.body.decode('utf-8')))
except:
elif content_type == 'multipart/form-data':
# TODO: Stream this instead of reading to/from memory
boundary = parameters['boundary'].encode('utf-8')
self.parsed_form, self.parsed_files = parse_multipart_form(self.body, boundary)
except Exception as e:
log.exception(e)
pass

return self.parsed_form

@property
def files(self):
if self.parsed_files is None:
_ = self.form # compute form to get files

return self.parsed_files

@property
def args(self):
if self.parsed_args is None:
Expand All @@ -70,3 +88,49 @@ def args(self):
self.parsed_args = {}

return self.parsed_args

File = namedtuple('File', ['type', 'body', 'name'])
def parse_multipart_form(body, boundary):
"""
Parses a request body and returns fields and files
:param body: Bytes request body
:param boundary: Bytes multipart boundary
:return: fields (dict), files (dict)
"""
files = {}
fields = {}

form_parts = body.split(boundary)
for form_part in form_parts[1:-1]:
file_name = None
file_type = None
field_name = None
line_index = 2
line_end_index = 0
while not line_end_index == -1:
line_end_index = form_part.find(b'\r\n', line_index)
form_line = form_part[line_index:line_end_index].decode('utf-8')
line_index = line_end_index + 2

if not form_line:
break

colon_index = form_line.index(':')
form_header_field = form_line[0:colon_index]
form_header_value, form_parameters = parse_header(form_line[colon_index+2:])

if form_header_field == 'Content-Disposition':
if 'filename' in form_parameters:
file_name = form_parameters['filename']
field_name = form_parameters.get('name')
elif form_header_field == 'Content-Type':
file_type = form_header_value


post_data = form_part[line_index:-4]
if file_name or file_type:
files[field_name] = File(type=file_type, name=file_name, body=post_data)
else:
fields[field_name] = post_data.decode('utf-8')

return fields, files
6 changes: 3 additions & 3 deletions sanic/response.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ def output(self, version="1.1", keep_alive=False, keep_alive_timeout=None):
])

def json(body, status=200, headers=None):
return HTTPResponse(ujson.dumps(body), headers=headers, status=status, content_type="application/json")
return HTTPResponse(ujson.dumps(body), headers=headers, status=status, content_type="application/json; charset=utf-8")
def text(body, status=200, headers=None):
return HTTPResponse(body, status=status, headers=headers, content_type="text/plain")
return HTTPResponse(body, status=status, headers=headers, content_type="text/plain; charset=utf-8")
def html(body, status=200, headers=None):
return HTTPResponse(body, status=status, headers=headers, content_type="text/html")
return HTTPResponse(body, status=status, headers=headers, content_type="text/html; charset=utf-8")
97 changes: 78 additions & 19 deletions sanic/sanic.py
Original file line number Diff line number Diff line change
@@ -1,30 +1,32 @@
import asyncio
from inspect import isawaitable
from traceback import format_exc
from types import FunctionType

from .config import Config
from .exceptions import Handler
from .log import log, logging
from .middleware import Middleware
from .response import HTTPResponse
from .router import Router
from .server import serve
from .exceptions import ServerError
from inspect import isawaitable
from traceback import format_exc

class Sanic:
name = None
debug = None
router = None
error_handler = None
routes = []

def __init__(self, name, router=None, error_handler=None):
self.name = name
self.router = router or Router()
self.router = router or Router()
self.error_handler = error_handler or Handler(self)
self.config = Config()
self.request_middleware = []
self.response_middleware = []

# -------------------------------------------------------------------- #
# Decorators
# Registration
# -------------------------------------------------------------------- #

# Decorator
def route(self, uri, methods=None):
"""
Decorates a function to be registered as a route
Expand All @@ -38,6 +40,7 @@ def response(handler):

return response

# Decorator
def exception(self, *exceptions):
"""
Decorates a function to be registered as a route
Expand All @@ -52,6 +55,34 @@ def response(handler):

return response

# Decorator
def middleware(self, *args, **kwargs):
"""
Decorates and registers middleware to be called before a request
can either be called as @app.middleware or @app.middleware('request')
"""
middleware = None
attach_to = 'request'
def register_middleware(middleware):
if attach_to == 'request':
self.request_middleware.append(middleware)
if attach_to == 'response':
self.response_middleware.append(middleware)
return middleware

# Detect which way this was called, @middleware or @middleware('AT')
if len(args) == 1 and len(kwargs) == 0 and callable(args[0]):
return register_middleware(args[0])
else:
attach_to = args[0]
log.info(attach_to)
return register_middleware

if isinstance(middleware, FunctionType):
middleware = Middleware(process_request=middleware)

return middleware

# -------------------------------------------------------------------- #
# Request Handling
# -------------------------------------------------------------------- #
Expand All @@ -65,13 +96,35 @@ async def handle_request(self, request, response_callback):
:return: Nothing
"""
try:
handler, args, kwargs = self.router.get(request)
if handler is None:
raise ServerError("'None' was returned while requesting a handler from the router")
# Middleware process_request
response = None
for middleware in self.request_middleware:
response = middleware(request)
if isawaitable(response):
response = await response
if response is not None:
break

# No middleware results
if response is None:
# Fetch handler from router
handler, args, kwargs = self.router.get(request)
if handler is None:
raise ServerError("'None' was returned while requesting a handler from the router")

# Run response handler
response = handler(request, *args, **kwargs)
if isawaitable(response):
response = await response

response = handler(request, *args, **kwargs)
if isawaitable(response):
response = await response
# Middleware process_response
for middleware in self.response_middleware:
_response = middleware(request, response)
if isawaitable(_response):
_response = await _response
if _response is not None:
response = _response
break

except Exception as e:
try:
Expand All @@ -90,14 +143,14 @@ async def handle_request(self, request, response_callback):
# Execution
# -------------------------------------------------------------------- #

def run(self, host="127.0.0.1", port=8000, debug=False, before_start=None, before_stop=None):
def run(self, host="127.0.0.1", port=8000, debug=False, after_start=None, before_stop=None):
"""
Runs the HTTP Server and listens until keyboard interrupt or term signal.
On termination, drains connections before closing.
:param host: Address to host on
:param port: Port to host on
:param debug: Enables debug output (slows server)
:param before_start: Function to be executed after the event loop is created and before the server starts
:param after_start: Function to be executed after the server starts listening
:param before_stop: Function to be executed when a stop signal is received before it is respected
:return: Nothing
"""
Expand All @@ -116,11 +169,17 @@ def run(self, host="127.0.0.1", port=8000, debug=False, before_start=None, befor
host=host,
port=port,
debug=debug,
before_start=before_start,
after_start=after_start,
before_stop=before_stop,
request_handler=self.handle_request,
request_timeout=self.config.REQUEST_TIMEOUT,
request_max_size=self.config.REQUEST_MAX_SIZE,
)
except:
pass
pass

def stop(self):
"""
This kills the Sanic
"""
asyncio.get_event_loop().stop()
Loading

0 comments on commit a74ab9b

Please sign in to comment.