Add client side encryption before Send files to S3

[gawsoftpl]

1. I added client side encryption before send files to S3. Encryption is synchronize, and encrypt and decrypt files with streams.
2. Update Readme and nx plugin config files.

[gawsoftpl]

@bojanbass Are you there?

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b574d16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

⌛ The following targets are in progress

• nx affected --target=build --parallel=3
• nx affected --target=e2e --parallel=3
• nx affected --target=test --parallel=3 --ci --code-coverage

🟥 Failed Commands
nx-cloud record -- yarn nx format:check

✅ Successfully ran 1 target

• nx affected --target=lint --parallel=3

---

Sent with 💌 from NxCloud.

[bojanbass]

@bojanbass Are you there?

Give me some time to review this. Thank you for the PR.

[gawsoftpl]

I fix e2e tests and fix format with "yarn format" command

[gawsoftpl]

I think that I have fixed all issues in my pull request.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c48bb4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 5 targets

• nx affected --target=test --parallel=3 --ci --code-coverage
• nx affected --target=lint --parallel=3
• nx affected --target=build --parallel=3
• nx affected --target=e2e --parallel=3
• nx-cloud record -- yarn nx format:check

---

Sent with 💌 from NxCloud.

[gawsoftpl]

Fixed all issues, please check.

[bojanbass]

I think this is ready to be merged. Can we cleanup git commit history or we just squash this?

[gawsoftpl]

squash this

[bojanbass]

squash this

Thank you for contribution and having patience with comments :)

[gawsoftpl]

Ok, but please read my last comment to your test:
#464 (comment)

[gawsoftpl]

I can add integration tests

But how to provide a way to run it with the same command on both environments and be consistent with nx targets?

Without docker or docker-compose I cant run minio server in clean and fast way. Best way is create new target "test-integration" with executor nx:run-commands like:

packages/nx-aws-cache/project.json

    "test-integration": {
      "executor": "nx:run-commands",
      "options": {
        "commands": [
          "docker-compose up -d",
          "npx jest aws-cache.integration.spec.ts"
        ],
        "cwd": "packages/nx-aws-cache"
      },
      "configurations": {
        "ci": {
          "ci": true
        }
      }
    }

[bojanbass]

I can add integration tests

But how to provide a way to run it with the same command on both environments and be consistent with nx targets?

Without docker or docker-compose I cant run minio server in clean and fast way. Best way is create new target "test-integration" with executor nx:run-commands like:

packages/nx-aws-cache/project.json

    "test-integration": {
      "executor": "nx:run-commands",
      "options": {
        "commands": [
          "docker-compose up -d",
          "npx jest aws-cache.integration.spec.ts"
        ],
        "cwd": "packages/nx-aws-cache"
      },
      "configurations": {
        "ci": {
          "ci": true
        }
      }
    }

So you would like to run docker-compose inside GitHub actions? What is the best way to do it? In GitLab, I would use services for example, where I would run minio as a service using docker, and expose it to be able to use in tests. This seems to me like a prerequisite to run tests, before running NX target. I'm not event sure if running docker-compose as a target works ok, because probably it won't stop automatically after the tests are completed, or will it?

[gawsoftpl]

So you would like to run docker-compose inside GitHub actions? What is the best way to do it? In GitLab, I would use services for example, where I would run minio as a service using docker, and expose it to be able to use in tests. This seems to me like a prerequisite to run tests, before running NX target. I'm not event sure if running docker-compose as a target works ok, because probably it won't stop automatically after the tests are completed, or will it?

Yes you are right. In gitlab best way to do it is use service to run minio. Equivalent in github will be prerequisite action. But there will be another issue how to run it with local dev tests?
Yes there is third requirement action to close docker-compose

The question is how to run additional service in nx pipeline in dev mode and in ci with one command?

All this gives the impression that nx is missing a plugin like @nx/service to run additional service for e2e tests to run service like in gitlab ci pipeline, which will run service and automatically close service. That service should run independent of system and should run in docker or podman.

It seems that there is a new idea for a plugin for nx

[bojanbass]

So you would like to run docker-compose inside GitHub actions? What is the best way to do it? In GitLab, I would use services for example, where I would run minio as a service using docker, and expose it to be able to use in tests. This seems to me like a prerequisite to run tests, before running NX target. I'm not event sure if running docker-compose as a target works ok, because probably it won't stop automatically after the tests are completed, or will it?

Yes you are right. In gitlab best way to do it is use service to run minio. Equivalent in github will be prerequisite action. But there will be another issue how to run it with local dev tests? Yes there is third requirement action to close docker-compose

The question is how to run additional service in nx pipeline in dev mode and in ci with one command?

All this gives the impression that nx is missing a plugin like @nx/service to run additional service for e2e tests to run service like in gitlab ci pipeline, which will run service and automatically close service. That service should run independent of system and should run in docker or podman.

It seems that there is a new idea for a plugin for nx

Yes, it's tricky. Maybe one idea is to make a custom executor which accepts buildTarget. This target could then run docker-compose locally (default configuration), but ci configuration wouldn't run it. Similar to something like this:

    "serve": {
      "executor": "@nx/js:node",
      "defaultConfiguration": "development",
      "configurations": {
        "development": {
          "buildTarget": "project:build:development"
        },
        "production": {
          "buildTarget": "project:build:production"
        }
      }
    },
    ```
Then, on CI, minio would already have to be running before executing targets. 

So, have you found out if it's possible ti run `docker-compose` down at the end of the tests?

[gawsoftpl]

I have created new discussion in nx nrwl/nx#20903

[bojanbass]

I have created new discussion in nx nrwl/nx#20903

Perfect!