-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: enable multi-processing on Linux #33
FIX: enable multi-processing on Linux #33
Conversation
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 25 25
Lines 1269 1275 +6
=======================================
+ Hits 1252 1258 +6
Misses 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @gregcaporaso, what do you think about that? It would at least make it use multiprocessing on Linux for now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misialq, this looks good to me. Just a couple of suggestions on the code.
Too bad it won't work on macOS right now! I would put a link to that issue (ablab/quast#175) in your code as a reminder of where to look to see if it's been resolved in the future - for example:
# This is a limitation in quast that is documented in this issue:
# https://github.com/ablab/quast/issues/175
Thanks for review @gregcaporaso! All updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @misialq! Do you want me to merge this, or will you take care of it on that end? (I haven't merged anything in this repo yet, so just want to check on what would be most helpful.)
I can take it from here, thanks! 🙏 |
Closes #32.
Unfortunately, multiprocessing seems not to be working on macOS, hence the platform check. See ablab/quast#175.