fix(index.tsx): make width and height properties optional in Size int… #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokuweb
reviewed
Apr 24, 2024
src/index.tsx
Outdated
| @@ -880,7 +874,7 @@ export class Resizable extends React.PureComponent<ResizableProps, State> { | |||
| } | |||
|
|
|||
| updateSize(size: Size) { | |||
| this.setState({ width: size.width, height: size.height }); | |||
| this.setState({ width: size.width || 'auto', height: size.height || 'auto' }); | |||
There was a problem hiding this comment.
Could you please use ?? instead of ||
Suggested change
| this.setState({ width: size.width || 'auto', height: size.height || 'auto' }); | |
| this.setState({ width: size.width ?? 'auto', height: size.height ?? 'auto' }); |
bokuweb
reviewed
Apr 24, 2024
src/index.tsx
Outdated
| @@ -870,7 +864,7 @@ export class Resizable extends React.PureComponent<ResizableProps, State> { | |||
| this.props.onResizeStop(event, direction, this.resizable, delta); | |||
| } | |||
| if (this.props.size) { | |||
| this.setState(this.props.size); | |||
| this.setState({ width: this.props.size.width || 'auto', height: this.props.size.height || 'auto' }); | |||
There was a problem hiding this comment.
Suggested change
| this.setState({ width: this.props.size.width || 'auto', height: this.props.size.height || 'auto' }); | |
| this.setState({ width: this.props.size.width ?? 'auto', height: this.props.size.height ?? 'auto' }); |
bokuweb
reviewed
Apr 24, 2024
src/index.tsx
Outdated
Comment on lines
392
to
393
| width: this.propsSize?.width ? this.propsSize && this.propsSize.width : 'auto', | ||
| height: this.propsSize?.height ? this.propsSize && this.propsSize.height : 'auto', |
There was a problem hiding this comment.
Suggested change
| width: this.propsSize?.width ? this.propsSize && this.propsSize.width : 'auto', | |
| height: this.propsSize?.height ? this.propsSize && this.propsSize.height : 'auto', | |
| width: this.propsSize?.width ?? 'auto', | |
| height: this.propsSize?.height ?? 'auto', |
|
@yushaku Thanks for your PR.Sorry for late. Could you please update README.md too? |
…erface to allow for undefined values
|
@bokuweb I updated it as you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
currently Resizable get props defaultSize with width and height and must enter value for both of them
In update: make width and height properties optional in Size interface to allow for undefined values and it allow user set value for one of them
when i read and update the code, i realize that i can set "auto" for width and height, but i did not got it in any docs then, i think this make lib more flex to use