Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Default row_start Band Component's content #905

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Oct 9, 2018

Jira

Related to http://vjira2:8080/browse/WWWD-2674

Summary

Adds a default row_start position value if no content_row_start config option is specified in the Band component.

How to test

Test band + social share examples using the new CSS Grid to confirm proper placement in IE 11 + Chrome.

@sghoweri sghoweri requested a review from remydenton October 9, 2018 18:59
@bolt-bot
Copy link
Collaborator

bolt-bot commented Oct 9, 2018

⚡ PR built on Travis and deployed a now preview here:

@sghoweri sghoweri merged commit 2473efe into master Oct 10, 2018
@sghoweri sghoweri deleted the fix/WWWD-2674--add-default-row-start branch October 10, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants