Fix: icon display issue in Safari #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
remydenton
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Looks like it works!
I noticed the new svgs are minified whereas the old ones weren't. Probably doesn't make much difference if we just consider them essentially the same as binary files/images (i.e. you shouldn't ever edit the files in Bolt, just re-export from Sketch).
|
Being OCD, I kind of want to re-save ALL of them, the ones under utility are very inconsistent... |
sghoweri
approved these changes
Nov 2, 2018
|
I'm going to go ahead and merge since this fixes the Safari problem. @mikemai2awesome, feel free to indulge your OCD in a separate PR :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-712
Summary
Fixes an issue with certain icons not rendering in Safari browsers.
Details
Certain icons were not appearing in Safari browsers due to the masking within the SVG files. I re-saved those icons without the masking and flatten them.
How to test
Run the branch locally, load up the icon demo page (http://localhost:3000/pattern-lab/?p=components-icon-name-variations) in Mac Safari and iOS Safari (using browserstack or xcode simulator). Make sure all icons render on the page.