Update TF to 2.6.0rc2 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also updates bindings for flatbuffer schema following the latest definition (schema_v3b).
boncheolgu
reviewed
Aug 20, 2021
|
Apologies for the delayed response. I updated the branch accordingly. I also want to ask you to check this. "model.buffers" here only have 24 elements, and erasing 23-rd element in the second line was impossible. |
boncheolgu
reviewed
Aug 31, 2021
| @@ -374,7 +394,7 @@ mod tests { | |||
| model.version = 2; | |||
| model.operator_codes.erase(4); | |||
| model.buffers.erase(22); | |||
| model.buffers.erase(23); | |||
| model.buffers.erase(22); // why it was okay before fixing it from 23 to 22? | |||
There was a problem hiding this comment.
I think you are right.
I will look into what's behind.
| @@ -3,4 +3,4 @@ | |||
| url = https://github.com/tensorflow/tensorflow.git | |||
| [submodule "submodules/downloads"] | |||
| path = submodules/downloads | |||
| url = https://github.com/boncheolgu/tflite-rs-downloads | |||
| url = https://github.com/yotarok/tflite-rs-downloads | |||
There was a problem hiding this comment.
Could you also submit a PR for the changes to https://github.com/boncheolgu/tflite-rs-downloads?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sending this with assuming that previous attempts to updating it to 2.4.1 is halting now.)
This PR updates the base Tensorflow version to 2.6.0rc2.
I think it is easy to again upgrade it to the official 2.6.0 once this is merged.
Upgrading to 2.6.0rc2 required a strange patch for making it compatible with macOS+LLVM environment.
yotarok/tflite-rs-downloads@29c578e
I hope it is okay, but I think I should dive a bit deeper to find a root cause of this.