Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boogie version #31

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

typerSniper
Copy link
Contributor

No description provided.

Copy link
Collaborator

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in here looks good to me. The lines you highlighted to review seem like they should be the right thing to do, to me, based on looking at Equals and HashCode for IdentifierExpr.

cmd.AddAssignedVariables(targets);

// JATIN_NOTE: CHECK THIS PLEASE
cmd.AddAssignedIdentifiers(targets.Select(t => new IdentifierExpr(Token.NoToken, t)).ToList());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is the right way to do it. Equality and hash codes are computed the same way as for the underlying variable.

cmd.AddAssignedVariables(modifiedVars);

// JATIN_NOTE: CHECK THIS PLEASE
cmd.AddAssignedIdentifiers(modifiedVars.Select(t => new IdentifierExpr(Token.NoToken, t)).ToList());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other location, I think this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants