UserMatchingPage 리팩토링 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- onClickHanlder를 MatchingCancelButton으로 이동
- 유저 매칭 페이지에서 불필요한 비동기 처리 제거 - 예상 요금에 toLocaleString 적용
- pathPoint를 Request로 바꿔주는 함수 분리 - request를 state에서 제거
- startTime을 state 대신 ref로 상태 관리
- taxiInfo가 변경될 일이 없기 때문에 useMemo로 래핑
ahnsoheee
approved these changes
Dec 17, 2020
| @@ -18,7 +18,7 @@ const PreRequestData: React.FC<PreRequestDataPropsType> = ({ time, fee }) => { | |||
| </Div> | |||
| <Div> | |||
| <p>예상요금</p> | |||
| <P>{fee}원</P> | |||
| <P>{fee.toLocaleString()}원</P> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 📎
#95
변경 사항 🛠
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️