Feature/#23 EPS, PER, 시가총액 등 주식 상세 정보 기능 추가 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjfcnfw3
approved these changes
Nov 12, 2024
| }) | ||
| @ApiOkResponse({ | ||
| description: '주식 상세 정보 조회 성공', | ||
| example: { |
There was a problem hiding this comment.
example 대신에 type: StockDetailResponse를 사용하면 StockDetailResponsed에서 설정한 example 값이 스웨거에 출력됩니다!
There was a problem hiding this comment.
감사합니다! 반영 완료했습니다!
| expect(managerMock.findBy).toHaveBeenCalledWith(StockDetail, { | ||
| stock: { id: stockId }, | ||
| }); | ||
| expect(result).toBeInstanceOf(StockDetailResponse); |
There was a problem hiding this comment.
instanceOf도 체크하시는 이유가 궁금합니다!
There was a problem hiding this comment.
너무 많은 것을 검증하려고 하면 오히려 리펙토링 내성이 약해질 우려가 있어서 질문했습니다!
There was a problem hiding this comment.
이 부분 피드백 감사합니다! 반영 완료했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #23
✅ 작업 내용
✍ 궁금한 점
😎 체크 사항