-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GWL-52] Logger 모듈 생성 #101
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,6 @@ | |
// | ||
|
||
import DesignSystem | ||
import OSLog | ||
import UIKit | ||
|
||
// MARK: - WorkoutEnvironmentSetupViewController | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import ProjectDescription | ||
import ProjectDescriptionHelpers | ||
|
||
let project = Project.makeModule( | ||
name: "Log", | ||
targets: .custom(name: "Log", product: .framework) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// | ||
// Log.swift | ||
// DesignSystem | ||
// | ||
// Created by 홍승현 on 11/23/23. | ||
// Copyright © 2023 kr.codesquad.boostcamp8. All rights reserved. | ||
// | ||
|
||
import OSLog | ||
|
||
/// 로그 | ||
public enum Log { | ||
|
||
/// Logger를 생성합니다. | ||
/// - Parameter category: Log를 구분하는 Category | ||
public static func make(with category: LogCategory = .default) -> Logger { | ||
return Logger(subsystem: .bundleIdentifier, category: category.rawValue) | ||
} | ||
} | ||
|
||
|
||
/// 로그 카테고리 | ||
public enum LogCategory: String { | ||
|
||
/// 기본값으로 들어갑니다. | ||
case `default` | ||
|
||
/// UI 로그를 작성할 때 사용합니다. | ||
case userInterface | ||
|
||
/// 네트워크 로그를 작성할 때 사용합니다. | ||
case network | ||
} | ||
|
||
|
||
private extension String { | ||
static let bundleIdentifier: String = Bundle.main.bundleIdentifier ?? "None" | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3
이거 번들 아이덴티파이어 항상 wetri로 출력되나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다. 이렇게 해도 괜찮겠다 싶었는데.. 지금 보니까 다시 생각이 바뀌었어요. 모듈마다 bundleIdentifier로 보이도록 수정할게요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다행히 로그에서는 모듈별로 로깅이 보이도록 해주네요! 따로 수정 안해도 될 것 같습니다 :)