Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with boost/integer #28

Closed

Conversation

georgthegreat
Copy link

Fixes compatibility regression introduced in 470537f.

@FireBurn
Copy link

FireBurn commented Nov 4, 2024

Thanks this fixes an error I was seeing:

error: implicit conversion loses integer precision: 'value_type' (aka 'unsigned long') to 'u32_le' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
   72 |     message.header.crc = crc.checksum();
      |                        ~ ~~~~^~~~~~~~~~

@georgthegreat
Copy link
Author

@pdimov, why not merge this (simpler) variant instead of
bd22b63

Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Nov 5, 2024
Besides the concepts issue, the other issue is caused by
boostorg/crc@470537f fixed by
boostorg/crc#28 but not sure if it will be merged.

Signed-off-by: Andrew Udvare <[email protected]>
Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Nov 5, 2024
Besides the concepts issue, the other issue is caused by
boostorg/crc@470537f fixed by
boostorg/crc#28 but not sure if it will be merged.

Signed-off-by: Andrew Udvare <[email protected]>
@pdimov pdimov closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants