Refactor library includes to #include <boost/gil/...> #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhenning
approved these changes
Sep 28, 2018
Group include directives, sort within group: * In headers of GIL core and extensions: 1. boost/gil/extension/* 2. boost/gil/* 3. boost/* 4. C++ standard library headers * In programs: 1. boost/gil/* 2. boost/* 3. C++ standard library headers 4. "xxx.hpp" for local headers Add basic guidelines to CONTRIBUTING.md. Add/Remove #include <boost/config.hpp> or std headers un/necessary. Rename gil_concept.hpp to concepts.hpp. Remove gil_all.hpp - we already have all-in-one boost/gil.hpp. Tidy up and unify copyright and license header. Tidy up formatting and excessive whitespaces in some comments. Remove Doxygen block with file description, author, date, etc. Remove dead or commented pragmas and directives. Trim trailing whitespaces.
mloskot
force-pushed
the
ml/includes-relative-to-boost-root-and-sorted
branch
from
89addd2 to
32fec9f
Compare
stefanseefeld
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group include directives, sort within group:
In headers of GIL core and extensions:
boost/gil/extension/*boost/gil/*boost/*In programs:
boost/gil/*boost/*"xxx.hpp"for local headersAdd basic guidelines to CONTRIBUTING.md.
Add/Remove
#include <boost/config.hpp>or std headers un/necessary.Rename
gil_concept.hpptoconcepts.hpp.Remove
gil_all.hpp- we already have all-in-oneboost/gil.hpp.Tidy up and unify copyright and license header.
Tidy up formatting and excessive whitespaces in some comments.
Remove Doxygen block with file description, author, date, etc.
Remove dead or commented pragmas and directives.
Trim trailing whitespaces.
This is quite a big changeset, so detailed review may be not quite practical, so I listed all kinds of changes in the log. I might have skipped listing one or two things, like
Add or copy TODO comment where obvious:-)References
Tasklist