Move tests of extensions inside test/ directory #302
Merged
+273
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
added
the
status/work-in-progress
mloskot
force-pushed
the
ml/move-extension-tests-into-test-dir
branch
4 times, most recently
from
22a5da5 to
8cd1f0d
Compare
Split header tests accordingly i.e. test core headers as part of core tests, numeric extension headers as part of numeric tests, etc. It extends the convention of sub-directories already established in `include/boost/gil` directory. It is sensible to follow it in other areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`). Another important reason to move the tests is to enable removal of the top-level `Jamfile` with all its definitions of test-specific requirements. The top-level `Jamfile` is not advised, especially if it specifies build requirements like C++ language version. Those affect non-tests builds e.g. documentation, causing failures during generation of HTML documentation (leads to missing docs).
mloskot
force-pushed
the
ml/move-extension-tests-into-test-dir
branch
from
8cd1f0d to
3260f1a
Compare
stefanseefeld
approved these changes
May 28, 2019
mloskot
removed
the
status/work-in-progress
|
@stefanseefeld We may have to merge into This looks good now |
mloskot
added a commit
that referenced
this pull request
May 28, 2019
mloskot
added a commit
to mloskot/gil
that referenced
this pull request
Sep 26, 2019
Split header tests accordingly i.e. test core headers as part of core tests, numeric extension headers as part of numeric tests, etc. It extends the convention of sub-directories already established in `include/boost/gil` directory. It is sensible to follow it in other areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`). Another important reason to move the tests is to enable removal of the top-level `Jamfile` with all its definitions of test-specific requirements. The top-level `Jamfile` is not advised, especially if it specifies build requirements like C++ language version. Those affect non-tests builds e.g. documentation, causing failures during generation of HTML documentation (leads to missing docs). (cherry picked from develop branch commit 4ed7701)
mloskot
added a commit
to mloskot/gil
that referenced
this pull request
Sep 26, 2019
Related to boostorg#302 (cherry picked from commit 628bfc2)
mloskot
added a commit
to mloskot/gil
that referenced
this pull request
Sep 26, 2019
Split header tests accordingly i.e. test core headers as part of core tests, numeric extension headers as part of numeric tests, etc. It extends the convention of sub-directories already established in `include/boost/gil` directory. It is sensible to follow it in other areas of the source tree (i.e. `test/`, `doc/` and `benchmark/`). Another important reason to move the tests is to enable removal of the top-level `Jamfile` with all its definitions of test-specific requirements. The top-level `Jamfile` is not advised, especially if it specifies build requirements like C++ language version. Those affect non-tests builds e.g. documentation, causing failures during generation of HTML documentation (leads to missing docs). (cherry picked from develop branch commit 4ed7701)
mloskot
added a commit
to mloskot/gil
that referenced
this pull request
Sep 26, 2019
Related to boostorg#302 (cherry picked from develop branch commit 628bfc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split header tests accordingly i.e. test core headers as part of
core tests, numeric extension headers as part of numeric tests, etc.
It extends the convention of sub-directories already established in
include/boost/gildirectory. It is sensible to follow it in otherareas of the source tree (i.e.
test/,doc/andbenchmark/).Another important reason to move the tests is to enable removal of
the top-level
Jamfilewith all its definitions of test-specificrequirements.
The top-level
Jamfileis not advised, especially if it specifiesbuild requirements like C++ language version.
Those affect non-tests builds e.g. documentation, causing failures
during generation of HTML documentation (leads to missing docs).
References
Tasklist
Jamfile-sCMakeLists.txt-sFYI, The unwanted top-level
Jamfilehas been confirmed (by @djarek and @pdimov) as what caused GIL docs build failures and not publishing them as part of Boost 1.70 docs.