Added kernel_2d classes to numeric extension #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miralshah365
force-pushed
the
kernel_2d
branch
2 times, most recently
from
5783bbb to
39dee36
Compare
mloskot
requested changes
Jul 31, 2019
There was a problem hiding this comment.
After the first round of the review, I have three issues:
- The storage is not optimal (see Added kernel_2d classes to numeric extension #361 (comment))
- The indexing is ambiguous (see Added kernel_2d classes to numeric extension #361 (comment))
- The PR subject
2D kernel support addedsuggests algorithms operating on 2D kernels have been also included, what does not seem to be the case. I'd suggest to change it to something like "Add 2D kernel definitions to numeric extension"
mloskot
added
the
status/work-in-progress
miralshah365
changed the title
miralshah365
force-pushed
the
kernel_2d
branch
3 times, most recently
from
020d49c to
49dc620
Compare
mloskot
requested changes
Aug 3, 2019
There was a problem hiding this comment.
@miralshah365 I added one extra request to replace assertions with exceptions. Other than that, it looks good to me. Once you make this change and CI-s pass, feel free to merge
miralshah365
force-pushed
the
kernel_2d
branch
2 times, most recently
from
56ff47b to
a7913bc
Compare
Tests for 2D numeric kernel added
mloskot
removed
the
status/work-in-progress
mloskot
reviewed
Aug 5, 2019
There was a problem hiding this comment.
Since the request in #361 (review) has been addressed, I'm happy to approve this.
mloskot
changed the title
mloskot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for more detail check the reference(s)
References
#356
Tasklist