Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image boundary extension algorithm added #386

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

lpranam
Copy link
Member

@lpranam lpranam commented Aug 30, 2019

Description

A new algorithm for image boundary extension added.
This can help with simplifying algorithms like convolution and median filter which is being implemented by @miralshah365.

While extending current convolve_2d this will allow all type of convolve options to be accommodated easily and current convolve_1d and also use to this to provide a uniform implementation.

References

#381

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added cat/feature New feature or functionality ext/numeric boost/gil/extension/numeric/ labels Aug 30, 2019
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is a bit modest.

I understand these are quite simple operations, but a user may expect to get description of motivation, when to use it (e.g. is it a sort of a method for canvas resize while keeping image content intact), what are (input) limitations if any, etc.

@lpranam
Copy link
Member Author

lpranam commented Sep 3, 2019

Added description as you suggested.
Took reference from this link:
https://caligari.dartmouth.edu/doc/idl/html_6.2/Padding_Images.html

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking the reference, it's an interesting resource.

I just have several requests for minor clean-ups (better to take care of it now than after merge).

@mloskot mloskot added this to the Boost 1.72+ milestone Sep 4, 2019
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your work.

I will leave the compilation warnings issue, if any, for your discretion.

@mloskot
Copy link
Member

mloskot commented Sep 5, 2019

@stefanseefeld Are you happy with Pranam's change addressing your #386 (comment) ?

@lpranam Is this ready to merge?

@lpranam
Copy link
Member Author

lpranam commented Sep 5, 2019

@lpranam Is this ready to merge?

@mloskot from my side it's ready

@mloskot mloskot merged commit 6a1c99a into boostorg:develop Sep 5, 2019
@mloskot
Copy link
Member

mloskot commented Sep 5, 2019

Thanks!

@lpranam lpranam deleted the boundary_extension branch September 14, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature New feature or functionality ext/numeric boost/gil/extension/numeric/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants