-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image boundary extension algorithm added #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is a bit modest.
I understand these are quite simple operations, but a user may expect to get description of motivation, when to use it (e.g. is it a sort of a method for canvas resize while keeping image content intact), what are (input) limitations if any, etc.
68d223b
to
3182d7e
Compare
Added description as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for linking the reference, it's an interesting resource.
I just have several requests for minor clean-ups (better to take care of it now than after merge).
3182d7e
to
aae0599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your work.
I will leave the compilation warnings issue, if any, for your discretion.
aae0599
to
5af3633
Compare
5af3633
to
c46f31e
Compare
c46f31e
to
c70c5ba
Compare
@stefanseefeld Are you happy with Pranam's change addressing your #386 (comment) ? @lpranam Is this ready to merge? |
Thanks! |
Description
A new algorithm for image boundary extension added.
This can help with simplifying algorithms like convolution and median filter which is being implemented by @miralshah365.
While extending current
convolve_2d
this will allow all type of convolve options to be accommodated easily and currentconvolve_1d
and also use to this to provide a uniform implementation.References
#381
Tasklist