Implemented median_filter #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
reviewed
Oct 1, 2019
miralshah365
force-pushed
the
median_filter
branch
from
092da74 to
5d6df23
Compare
mloskot
requested changes
Oct 7, 2019
miralshah365
force-pushed
the
median_filter
branch
from
5d6df23 to
f448f2c
Compare
mloskot
reviewed
Oct 13, 2019
mloskot
reviewed
Oct 13, 2019
mloskot
reviewed
Oct 13, 2019
miralshah365
force-pushed
the
median_filter
branch
from
f448f2c to
0575fe4
Compare
mloskot
requested changes
Oct 13, 2019
There was a problem hiding this comment.
@miralshah365 Good work.
The only important comment I have is about the optimisation of std::vector use.
Once we resolve that one, your PR is ready to merge.
tests for median_filter added
miralshah365
force-pushed
the
median_filter
branch
from
0575fe4 to
f8aa340
Compare
mloskot
approved these changes
Oct 13, 2019
There was a problem hiding this comment.
@miralshah365 Thank you for your prompt updates. It looks good. Feel free to merge as soon as all our CI-s pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented
median_filterfunctiontests added for
median_filterThis utility will provide a way to remove noise from the image by choosing a median value from a window which iterates over entire image.
Tasklist