-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix any_image_view::const_t #526
Fix any_image_view::const_t #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting catch! LGTM, just a few nitpicks
I found an other issue similar to #486 (aka |
I thought using inheriting constructors was the right think to do, but it looks like it fails with GCC5, is it C++11 feature complete? |
https://gcc.gnu.org/projects/cxx-status.html#cxx11 says
However, we have dropped support from GCC 4.8 as its C++11 support is unusable for GIL (and Boost.MP11 too), see #296 Perhaps GCC 5 is lacking or suffering a bug. |
Do you want to support GCC5, in which case I can revert to declaring every constructors (including the missing one to support initializing construction)? |
Good question. Dropping support for GCC 5 could be part of switching to C++17 which was seeded on the Slack, https://cpplang.slack.com/archives/CSVT0STV2/p1588870474195500 |
Not sure if this is the one, but there are bugs related to inheriting constructors in GCC 5: |
@sdebionne Any workaround to keep compatible w/ GCC 5 is best option for the time being. UPDATE: See also @pdimov 's suggestion here https://lists.boost.org/Archives/boost/2020/10/250222.php |
I am OK with both approaches, aka workaround or dropping GCC 5, but the later and making C++ 14 the new language std requirement is more appealing to me. |
@sdebionne Yes, let's prepare for the step towards C++14, https://lists.boost.org/boost-gil/2020/10/0469.php |
@mloskot To clarify for 1.75, are we dropping GCC 5 (in which case the checks should pass and this PR could be merged) or do you prefer a workaround? Or are we too late anyway? |
1.75 has just been frozen for beta. |
No, I don't think it's right to drop GCC 5 or start requiring C++14 from 1.75. |
I've announced our plans in the release notes, 8b1c2d3 and boostorg/website#562 |
Clarification suggested in boostorg/website#562 following discussion about #526
If I am correct, I need to close and reopen the PR to get the updated pipeline without GCC5? Or is there a better way? |
@sdebionne I think you need to rebase your |
d52ee44
to
c2c44b8
Compare
Done. But I still see gcc-5 on Azure and gcc-4.9 on Github Actions, both versions probably impacted by the bug mentioned before. |
Required by boostorg#526 See also boostorg/website#562
Required by boostorg#526 See also boostorg/website#562
@sdebionne Sorry, there had been no update to our CI. Fixing in #572 |
Required by #526 See also boostorg/website#562 Disable system.debug on AzP
@sdebionne The #572 has been merged. If you could update this PR with the develop, then it should build fine. |
c2c44b8
to
b8f48bc
Compare
How should I interpret the result of the CI:
|
Required by boostorg#526 See also boostorg/website#562 Disable system.debug on AzP
If you are asking me, I would say yes! Or do I need to rebase? |
Thanks |
Clarification suggested in boostorg/website#562 following discussion about boostorg#526
Required by boostorg#526 See also boostorg/website#562 Disable system.debug on AzP
Use inherited constructors in any_image as well
Clarification suggested in boostorg/website#562 following discussion about boostorg#526
Required by boostorg#526 See also boostorg/website#562 Disable system.debug on AzP
Use inherited constructors in any_image as well
Clarification suggested in boostorg/website#562 following discussion about boostorg#526
Required by boostorg#526 See also boostorg/website#562 Disable system.debug on AzP
Use inherited constructors in any_image as well
Clarification suggested in boostorg/website#562 following discussion about boostorg#526
Required by boostorg#526 See also boostorg/website#562 Disable system.debug on AzP
Use inherited constructors in any_image as well
Clarification suggested in boostorg/website#562 following discussion about boostorg/gil#526
Clarification suggested in boostorg/website#562 following discussion about boostorg/gil#526
See discussion in boostorg#526 Cherry-pick of 8b1c2d3 from develop.
…#664) See discussion in #526 Cherry-pick of 8b1c2d3 from develop. Co-authored-by: Mateusz Łoskot <[email protected]>
Let's do it for Boost 1.80. I have moved the planning towards C++14/17 to discussion here #676 |
Description
Fix
any_image_view<>::const_t
that currently returns an invalid type, see the provided test case that fails ondevelop
.Tasklist