Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default ctor of homogeneous_color_base for reference pixel elements #542

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Jan 21, 2021

Description

If Element is a reference, then Element v{} is ill-formed.

References

Tasklist

  • Add test case(s) - already in place
  • Ensure all CI builds pass - Travis CI, R.I.P.
  • Review and approve (via #boost at Slack)

If `Element` is a reference, then Element v{} is ill-formed.
@mloskot mloskot added the cat/bug But reports and bug fixes label Jan 22, 2021
@mloskot mloskot added this to the Boost 1.76+ milestone Jan 22, 2021
@mloskot mloskot merged commit 470923b into boostorg:develop Jan 22, 2021
@mloskot mloskot deleted the ml/fix-homogeneous_color_base-for-reference-channel-pixel branch January 22, 2021 17:01
mloskot added a commit to mloskot/gil that referenced this pull request Jan 25, 2021
mloskot added a commit that referenced this pull request Jan 25, 2021
* ci: Add configuration for GitHub Actions

Add basic GitHub Actions configuration based on mp11
Remove Actions jobs using GCC 4.7 and 4.8 - unsupported compilers
Run b2 with --abbreviate-paths on Windows
The -std=c++1z is broken for clang-4.0 but no need to test it
Add -mbig-obj to GCC on Windows
  - That is to avoid string table overflow and file too big
Define _GLIBCXX_USE_CXX11_ABI=0 for clang 3.5, 3.6, 3.7
  - Should help avoid linker error:
    `undefined reference to std::ios_base::failure::failure(char const*, std::error_code const&)`
Disable certain check in algorithm_channel_relation test for clang<3.8

(cherry picked from develop commit 81b4dc0)

* ci: Disable GA build with clang 3.5 until fix #542 is merged into master
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 21, 2021
…ts (boostorg#542)

If `Element` is a reference, then Element v{} is ill-formed.

Refines boostorg#273 which aimed to correctly value-initialize channel and pixel value members
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 22, 2021
…ts (boostorg#542)

If `Element` is a reference, then Element v{} is ill-formed.

Refines boostorg#273 which aimed to correctly value-initialize channel and pixel value members
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug But reports and bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant