-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed most of warnings in examples and some in core library #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update this PR to get the latest changes from the develop
branch?
bf565d4
to
e4cfa2b
Compare
@mloskot Yes, I have done that now, rebased my branch on current develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I suggested a few improvements
e4cfa2b
to
f1d56e7
Compare
f1d56e7
to
e955589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Completing boostorg#545
Completing boostorg#545
Completing boostorg#545
Completing boostorg/gil#545
Completing boostorg/gil#545
Description
This PR fixes multiple warnings showing up during boost build process. Including the fixes of the examples, and some other warnings from core header files.
References
#436
gil/include/boost/gil/channel.hpp
Line 651 in 81b4dc0
Fixing this warning causes a test to fail and I couldn't figure out why that was happening, so I skipped fixing that one for now.
Tasklist