-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix C++20 incompatibilities in IO extensions #617
Fix C++20 incompatibilities in IO extensions #617
Conversation
LGTM and thanks for the fix! I remember asking myself what were this |
Codecov Report
@@ Coverage Diff @@
## develop #617 +/- ##
========================================
Coverage 78.72% 78.72%
========================================
Files 118 118
Lines 5034 5034
========================================
Hits 3963 3963
Misses 1071 1071 |
I believe the build issues in |
From what I read on slack, the GHA guys have fun changing the docker images without notice. I am not a CI guru, @mloskot can this be easily fixed? Apparently |
@mloskot I'd like to merge this one, any objection? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@sdebionne Please, do. Thank you for nudging me about it. Sorry, I have no having any solution for the CI issues right now. I should be able to look at that next month. |
@mloskot No worries and unfortunately I don't have time to look at the CI neither... but this should be safe to merge. |
Description
Replace the simple-template-ids used in the IO extension tags as constructor names for specializations of
image_read_info
andimage_read_settings
with the associated plain class names.References
resolves #616
Tasklist