-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all examples build without error #628
Ensure all examples build without error #628
Conversation
I have a few questions:
|
Hi, first thanks for your contribution, it's helpful.
I don't think we should care about describing the examples in the documentation.
I'm not sure I understand.
You'd have to be more specific what you are doing, what is the output, errors, etc. Here is (new home of) B2 with its documentation: |
Alright, I will include that in the tasklist then.
Apologies, I wasn't being super clear: should the default target in the top Jamfile also include producing the executable files for the examples now, or do we leave it as it is today (i.e.
Indeed, I just didn't want to turn this thread into a support ticket. I will open a separate ticket.
I read it a few times and couldn't find the section that would help me with my problem so far... I'm clearly missing something. |
Regarding the issue with linking: it was a problem with the project-cache.jam not being updated. Deleting this file and rebuilding fixed it. |
Yes, the GIL's top-level Jamfile can also build the examples. AFAICT, all Boost's CI services do |
c22a18e
to
537f8ae
Compare
I just updated the PR with some explanations for the examples. |
Good catch, yes, all source files should have the licence/copyright header comment, like this: Lines 1 to 7 in 537f8ae
|
537f8ae
to
bef4b91
Compare
Thank you for your remarks! I've updated the attributions and the Jamfile indent. |
I noticed example/convolve2d.cpp was a bit off compared to the other examples: one output file had a I cleaned it up. This is the last of the changes I can see we can bring here: if you find all is well, then I think we can add the target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It all looks good to me. Thanks!
Thank you for your time! I just added the target |
Thank you for your contribution |
Description
Add all examples to example/Jamfile
Add necessary 'using' for libpng
Bring small fixes to examples' source files (remove unused variables)
Environment:
References
See #436
Tasklist