Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value to tuple #515

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Value to tuple #515

merged 3 commits into from
Apr 26, 2021

Conversation

grisumbras
Copy link
Member

Fix #508

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #515 (00d620c) into develop (bd5c548) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 00d620c differs from pull request most recent head aae1863. Consider uploading reports for the commit aae1863 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #515   +/-   ##
========================================
  Coverage    99.10%   99.10%           
========================================
  Files           67       67           
  Lines         6049     6057    +8     
========================================
+ Hits          5995     6003    +8     
  Misses          54       54
Impacted Files Coverage Δ
include/boost/json/detail/value_traits.hpp 100.00% <ø> (ø)
include/boost/json/detail/value_to.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d65b0a...aae1863. Read the comment docs.

@grisumbras grisumbras requested a review from vinniefalco March 3, 2021 20:14
@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

vinniefalco
vinniefalco reviewed Mar 3, 2021
View reviewed changes
include/boost/json/detail/index_sequence.hpp
#if ! defined(BOOST_JSON_STANDALONE)

template <std::size_t... Is>
using index_sequence = boost::mp11::index_sequence<Is...>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@vinniefalco
Copy link
Member

I really don't have the skills to review stuff related to value_to and value_from. @pdimov ?

@pdimov
Copy link
Member

pdimov commented Mar 3, 2021

If it passes msvc-14.0 CI it's probably good.

@pdimov
Copy link
Member

pdimov commented Mar 3, 2021

Looks good to me. To repeat what I said on Slack, now that tuple-likes are supported it looks like general maps (where the key is not string-like) would also start working (being treated as sequences of pairs.) If they do work, we need to have a test for it. If they don't, we might want to look into why.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://515.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://515.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://515.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/515/pullrequest.html

@grisumbras grisumbras merged commit aae1863 into boostorg:develop Apr 26, 2021
@grisumbras grisumbras deleted the value-to-tuple branch April 26, 2021 05:48
@grisumbras grisumbras mentioned this pull request May 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinniefalco vinniefalco vinniefalco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

value_to tuple/pair
4 participants
@grisumbras @cppalliance-bot @vinniefalco @pdimov