Catch OSX sonoma iconv issue #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
catch_osx-sonoma-iconv-issue
branch
from
f0fda30 to
baa4698
Compare
This was referenced Feb 8, 2024
Closed
Flamefire
force-pushed
the
catch_osx-sonoma-iconv-issue
branch
from
69b2555 to
5ddf9c6
Compare
This reverts commit 116b589.
E2BIG shall be returned if the output buffer is too small. We pass a 64 byte buffer which should be enough to do *something* However it is observed on MacOS Sonoma that iconv returns E2BIG without doing any progress leading to an infinite loop as the same inputs will be passed over and over. See boostorg#206. Instead raise an exception when this case is detected.
Flamefire
force-pushed
the
catch_osx-sonoma-iconv-issue
branch
from
0724909 to
e5feae6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 95.72% 95.72%
========================================
Files 116 116
Lines 9930 9937 +7
========================================
+ Hits 9505 9512 +7
Misses 425 425
Continue to review full report in Codecov by Sentry.
|
Iconv still fails to behave correctly: - Testing correct invalid bytes skipping -- UTF-8 --- At start single ----- [IConv] --- At start multiple ----- [IConv] --- At middle single Error in line 167: to_utf<Char>(source, encoding) == target ---- [g] != [grU+00FCU+00DFen] Error in line 77: conv(source) == target ---- [g] != [grU+00FCU+00DFen] ----- [IConv] Error in line 85: convPtr->convert(source) == target ---- [g] != [grU+00FCU+00DFen] and: -- Error for decoding to UTF-8 Error in line 188: from_utf<Char>(source, encoding) == target ---- [gr�����üßen] != [grüßen]
Flamefire
force-pushed
the
catch_osx-sonoma-iconv-issue
branch
from
2686245 to
5f2a828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2BIG shall be returned if the output buffer is too small.
We pass a 64 byte buffer which should be enough to do something
However it is observed on MacOS Sonoma that iconv returns E2BIG without
doing any progress leading to an infinite loop as the same inputs will
be passed over and over.
Instead raise an exception when this case is detected.
Closes #206