Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements - Filename and text context #244

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

Flamefire
Copy link
Collaborator

To better determine the position of a failed test print the filename in the error message and add support for context-messages:

The first is useful for tests in commonly used headers, the latter in loops over different test inputs

@Flamefire Flamefire force-pushed the test-refactor branch 2 times, most recently from c303689 to d934fc5 Compare December 1, 2024 17:52
Also move the error reporting to a single function
Avoid to require manual output in anticipation of failures.
@Flamefire Flamefire enabled auto-merge December 1, 2024 18:45
@Flamefire Flamefire changed the title Test improvements Test improvements - Filename and text context Dec 1, 2024
@Flamefire Flamefire merged commit a996b00 into develop Dec 2, 2024
53 checks passed
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (69e0e30) to head (f0d95b0).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #244   +/-   ##
========================================
  Coverage    95.81%   95.81%           
========================================
  Files          117      117           
  Lines        10352    10352           
========================================
  Hits          9919     9919           
  Misses         433      433           
Files with missing lines Coverage Δ
test/test_catalog.cpp 100.00% <100.00%> (ø)
test/test_codecvt.cpp 100.00% <100.00%> (ø)
test/test_date_time.cpp 100.00% <ø> (ø)
test/test_encoding.cpp 100.00% <100.00%> (ø)
test/test_formatting.cpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e0e30...f0d95b0. Read the comment docs.

@Flamefire Flamefire deleted the test-refactor branch December 2, 2024 20:00
@Flamefire Flamefire restored the test-refactor branch December 2, 2024 20:04
@Flamefire Flamefire deleted the test-refactor branch December 2, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant