Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: directly define project version #1199

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

lucascolley
Copy link
Contributor

@mborland
Copy link
Member

These changes look fine to me. The real question is will this be better for you? About 2 years ago when Scipy moved to using the Boost.Math standalone submodule (scipy/scipy#17432) you were able to start tracking the head commit of math instead of having to wait for the tri-annual release. Won't this put you back in a position where you are waiting potentially months for fixes or features? Example. I am pretty sure your implementation of the Landau distribution relies on ours right now (through _ufuncs), but the Landau distribution has not made any official release for us yet and will not until 11 December at the earliest.

@lucascolley
Copy link
Contributor Author

The real question is will this be better for you? About 2 years ago when Scipy moved to using the Boost.Math standalone submodule (scipy/scipy#17432) you were able to start tracking the head commit of math instead of having to wait for the tri-annual release. Won't this put you back in a position where you are waiting potentially months for fixes or features?

Indeed, there is a trade-off to be made there. We haven't made that decision yet, but these changes will enable us to go either way.

@mborland
Copy link
Member

Indeed, there is a trade-off to be made there. We haven't made that decision yet, but these changes will enable us to go either way.

Sounds good. Since this adds a maintenance burden of like 30 seconds every 4 months I am not opposed.

@mborland mborland merged commit ff72eaa into boostorg:develop Sep 16, 2024
76 of 77 checks passed
@lucascolley lucascolley deleted the cmake_version branch September 16, 2024 13:15
@lucascolley
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants