Fix v1 tests after v2 became the default #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2ccd97c, v2 is the default when using the unversioned includes. This broke the v1 tests which were still using those.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2ccd97c, v2 is the default when using the unversioned includes. While working on #449, I noticed that this broke the v1 tests which were still using them.
I'm not sure what the plan is for the v1 tests. I've seen that they have been disabled in the Jamfile
process/test/Jamfile.jam
Lines 6 to 7 in b529769
so I assume that is intentional? At the same time, the CMake project still includes the v1 subdirectory:
process/test/CMakeLists.txt
Lines 2 to 3 in b529769
I don't know if the two build systems are manually kept in sync and this was an oversight, or if there's tooling to regenerate the CMake files at some point?
Anyway, I would advocate either reinstating the v1 tests (in which case I hope that this PR saves you some time), or deleting them altogether, including from the CMake file.