-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libdwfl based implementation #187
base: develop
Are you sure you want to change the base?
Conversation
@apolukhin, please have a look at this draft. Note, I was using CMake and |
Tests are missing. You will need to write some b2 scripts: follow this sample Lines 80 to 93 in 344f6ba
Lines 34 to 40 in 344f6ba
After that adjust https://github.com/boostorg/stacktrace/blob/develop/test/Jamfile.v2 by adding each of the tests with libdwfl |
This commit adds an implementation based on libdwfl from elfutils. Implements boostorg#176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay. The PR looks very good!
A few more things to fix:
- As I see in CI runs the
dw
library is not found and the new functionality is not tested. Please adjust the content of.github/workflows/
directory to test the new implementation - One of the Boost specific linters complains that the build/has_dwfl.cpp, include/boost/stacktrace/detail/libdwfl_impls.hpp, src/dwfl.cpp files have no
Copyright
notes. Copypaste the Copyright message and place your name in it (or place my name if you wish to remain anonymous)
This commit adds an implementation based on
libdwfl
fromelfutils
.Implements #176