Fix shared_mutex and future time jump tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the develop branch. This discarded all changes made to these two files in the feature/timespec_clocks branch to date.
- This allowed these classes to take advantage of the time jump fixes in condition_variable. Fixed a minor issue where, if a thread was waiting after calling one of the following functions and it timed out at the same time it was given the lock, it would return false (failure) rather than succeeding. - mutex::timed_lock() - mutex::try_lock_for() - mutex::try_lock_until() - recursive_mutex::timed_lock() - recursive_mutex::try_lock_for() - recursive_mutex::try_lock_until() - shared_mutex::timed_lock_shared() - shared_mutex::try_lock_shared_for() - shared_mutex::try_lock_shared_until()
|
Here are the test results from this PR. https://github.com/austin-beer/test-time-jumps/blob/master/linux_results_austin_no_monotonic.txt The only fixable failures that still need to be fixed after this PR are in: |
|
Thanks a lot for almost fixing everything. |
austin-beer
deleted the
feature/timespec_clocks_pr18_use_pred_overloads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is composed of two commits.
The first commit simply reverts
pthread/shared_mutex.hppandfuture.hppback to the versions indevelop, which reverts all of the changes we've made to these two files to date.The second commit re-fixes the time jump issues by using the predicate versions of the wait functions, which is a simpler solution than the one we were using before and which works even with the changes we made to avoid losing notifications.