Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Tool Call Argument Handling for Ollama Integration #29

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

vijaythecoder
Copy link
Contributor

@vijaythecoder vijaythecoder commented Jul 20, 2024

Issue:

  • Fixed a bug where the field for tool calls was not always formatted correctly as a JSON object, leading to a error from the Ollama API.

Enhancements and Fixes:

  1. ChatRequest Enhancements:

    • Modified the class in to ensure that the field is always a valid JSON object. This fix provides compatibility for the new which works offline.
  2. ChatAssistant Updates:

    • Adjusted logic in the class in related to handling messages and tool calls.
  3. Service Request Enhancements:

    • Updated the request handling in to improve argument handling and tool call structuring.
  4. Onboarding Steps:

    • Added minor adjustments to the class in to ensure smooth user onboarding and configuration setup.
  5. Database Configuration:

    • Updated to include additional database configuration options and ensure appropriate environment variable usage.

Testing:

  • Reproduced the issue and verified that the error was resolved after the enhancements.
  • Ensured that the arguments for tool calls are now correctly formatted as JSON objects.

Additional Information:

  • This PR is created by GPT-4o. It has written the entire PR and solved the issue for Ollama with proper user input.

The provided changes ensure that the integration with Ollama works seamlessly with the appropriate argument formats and additional improvements in services and database configuration.

@vijaythecoder vijaythecoder force-pushed the enhance-ollama-tool-use branch from 9e6a1b2 to e6a8284 Compare July 20, 2024 07:38
vijaythecoder

This comment was marked as resolved.

@vijaythecoder vijaythecoder merged commit c4ca06a into dev-1.1.1 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant