Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select by burstId in crop_burst_dataset #100

Merged

Conversation

aurghs
Copy link
Member

@aurghs aurghs commented Apr 15, 2022

close #80

Things to do:

  • update code
  • add tests (need a newer image)
  • document the new option

@codecov-commenter
Copy link

Codecov Report

Merging #100 (b1b518e) into main (9602897) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   91.02%   91.46%   +0.44%     
==========================================
  Files          12       12              
  Lines         880      914      +34     
  Branches       96      100       +4     
==========================================
+ Hits          801      836      +35     
  Misses         57       57              
+ Partials       22       21       -1     
Impacted Files Coverage Δ
tests/test_20_sentinel1.py 98.07% <100.00%> (+0.16%) ⬆️
tests/test_30_xarray_backends.py 100.00% <100.00%> (ø)
xarray_sentinel/sentinel1.py 87.20% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9602897...b1b518e. Read the comment docs.

@aurghs aurghs marked this pull request as ready for review April 19, 2022 15:45
@alexamici alexamici merged commit 95cf3f9 into main Apr 19, 2022
@alexamici alexamici deleted the 80_add_option_to_select_by_burstId_in_crop_burst_dataset branch April 19, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to select by burstId in crop_burst_dataset
3 participants