Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor attribute definition and location #101

Merged
merged 6 commits into from
Apr 21, 2022

Conversation

alexamici
Copy link
Member

Closes #88

@alexamici alexamici linked an issue Apr 20, 2022 that may be closed by this pull request
@alexamici alexamici requested a review from aurghs April 21, 2022 09:00
@codecov-commenter
Copy link

Codecov Report

Merging #101 (90ef68e) into main (7080ea4) will decrease coverage by 0.35%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   91.46%   91.11%   -0.36%     
==========================================
  Files          12       12              
  Lines         914      923       +9     
  Branches      101      101              
==========================================
+ Hits          836      841       +5     
- Misses         57       61       +4     
  Partials       21       21              
Impacted Files Coverage Δ
tests/test_30_xarray_backends.py 100.00% <ø> (ø)
xarray_sentinel/esa_safe.py 85.39% <55.55%> (+0.33%) ⬆️
xarray_sentinel/reformat.py 68.00% <60.00%> (-10.95%) ⬇️
tests/test_10_esa_safe.py 100.00% <100.00%> (ø)
xarray_sentinel/sentinel1.py 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7080ea4...90ef68e. Read the comment docs.

@alexamici alexamici merged commit 3253d2f into main Apr 21, 2022
@alexamici alexamici deleted the 88-refactor-attribute-definition-and-location branch April 21, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor attribute definition and location
3 participants