Added output for create function. Solves #3561 #4105
Conversation
Create now logs directory name upon completion
Creation function now outputs repository name upon completion.
| @@ -534,6 +534,7 @@ def create_inner(archive, cache, fso): | |||
| process_file_chunks=cp.process_file_chunks, add_item=archive.add_item, | |||
| chunker_params=args.chunker_params, show_progress=args.progress) | |||
| create_inner(archive, cache, fso) | |||
| logger.error("Repository %s has been created successfully" % archive.name) | |||
There was a problem hiding this comment.
Why output it on error level? Check the available logging levels to find something more appropriate.
Also, you are saying "Repository %s", but what you fill into the placeholder is the archive's name, not the repository URL.
| @@ -534,6 +534,7 @@ def create_inner(archive, cache, fso): | |||
| process_file_chunks=cp.process_file_chunks, add_item=archive.add_item, | |||
| chunker_params=args.chunker_params, show_progress=args.progress) | |||
| create_inner(archive, cache, fso) | |||
| logger.error("Repository %s has been created successfully" % archive.name) | |||
| else: | |||
| create_inner(None, None, None) | |||
There was a problem hiding this comment.
in this branch, there will be no output with your modification. but guess there should be.
dry-run is to simulate a backup run without really writing something, the messages can be the same though.
also maybe move it to before the recursion is started and say something like "Creating archive ... in repository ....".
then we will have that output even in case the backup is aborted later. the final success state is available via --show-rc.
|
there is some breakage in the tests, see above. |
|
@JoshuaRM did you see my feedback? |
|
No response, no activity - closing this. |
Solved issue #3561.
The create function now logs the name of the repository to std.err
The output logs the message "Repository x has been created successfully". Where x is the repo name