Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: borg-serve: simplify example of env in authorized_keys #8331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qyanu
Copy link
Contributor

@qyanu qyanu commented Aug 11, 2024

see #8318

so long as it can be assumed that the user has configured a POSIX compliant login shell, using a simple command [1] looks cleaner, as no export or ; are used.

[1] Section "2.9.1 Simple Commands" in volume "Shell & Utilities" of POSIX.1-2024

@qyanu qyanu force-pushed the 3818simplifyexport-master branch from d80648d to d8c0fa6 Compare August 11, 2024 17:13
@qyanu
Copy link
Contributor Author

qyanu commented Aug 11, 2024

While thinking about issue #8318 i noticed, that the recommended authorized_keys command to set a BORG_XXX environment variable can do without the ";" and "export". so i just quickly created this pull request.

@qyanu qyanu changed the title docs: borg-serve: simplify example of env in authorized_keys, see #8318 docs: borg-serve: simplify example of env in authorized_keys Aug 11, 2024
@ThomasWaldmann
Copy link
Member

Looks good IMHO/AFAIK.

I guess we'll keep this open for a while in case somebody has objections.

see borgbackup#8318

so long as it can be assumed that the user has configured a POSIX
compliant login shell, using a simple command [1] looks cleaner, as
no ``export`` or ``;`` are used.

[1] Section "2.9.1 Simple Commands" in volume "Shell & Utilities" of POSIX.1-2024
@qyanu qyanu force-pushed the 3818simplifyexport-master branch from 6c18a99 to 75687b4 Compare January 4, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants