-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in building MATLAB wrapper: No module named 'gtwrap' #1118
Error in building MATLAB wrapper: No module named 'gtwrap' #1118
Comments
Thanks for reporting! It'll be about a few days before I can look into this (since we're all trying to make IROS 22 deadlines), but it looks like it should be a simple fix. |
Any idea where the problem could be arising from? |
also getting the same error when building, any resolution? |
@varunagrawal we don’t’ have to “git clone” with some sub tree flag, right? At least, I remember it works out of the box for me. |
@SarveshS325 the issue is that you're using a conda environment, so you'll need to specify the values for |
@varunagrawal, if that were the case I should not have been able to build python bindings either. I have tried with system python3 outside conda environment and setting the |
Fair point. Can you please share the GTSAM branch and commit you are trying to build? |
I am building from the source archive of the 4.1.1 release |
Oh then it seems like a bug creeped in that was subsequently fixed. We don't have a CI for Matlab which is why it wasn't caught before, so I apologize for that. Do you mind building the latest |
Quick update: even develop has some issues :-( I'll put in a PR in a few minutes. |
Yup, just checked.
|
@SarveshS325 @frank-Regal can you please try with the latest develop? |
@varunagrawal No, still the same issue
|
Can you please post the error message? |
It is the same as in the original issue
|
Can you change that line in |
This is very weird, especially since the python wrapper works for you. Both wrappers have a line Would you mind clearing your build directory and recompiling from scratch? The CMake cache may not have updated. Also please make sure you're on commit d0a1852. |
I have tried starting with a squeaky clean build and I am on |
I have the same problem, is there a solution now?
Error message:
|
@SarveshS325 @wxchencn I recently made some updates to the wrapper. Can you please try again? |
Error message: Thanks very much! |
Can you try the latest develop branch please? |
I have tried the latest develop branch and have the same error. Thanks very much! |
I try the version GTSAM 4.0.3 Release , and the problem does not appear. Thanks very much!
|
Can you add this on line 254 of MatlabWrap.cmake and give us the output? message(">>>>>>>>>>> PYTHONPATH=${GTWRAP_PACKAGE_DIR}${GTWRAP_PATH_SEPARATOR}$ENV{PYTHONPATH}") |
Also please paste the full message here please, starting from the output of CMake. |
@SarveshS325 @YeXiaoYu539 please give us the full message and error log so we can see what is going on in your settings. We have an idea of what the issue may be but we need to confirm it. |
Can you also provide your CMake versions? |
Cmake Output
|
|
|
Thanks for the info. Can you try fixing that Cmake warning? That may actually be your issue (and we should make that an error rather than a warning). |
If you're using the system python, the fix is to do |
@SarveshS325 @YeXiaoYu539 @frank-Regal I figured out the issue!!! PR #1235 fixes this. 🎉 |
Can you please comment on whether the latest develop branch works for you? |
Thanks very much! I have already tried the latest develop branch, it indeed fixes the problem! |
Description
I am trying to build the MATLAB wrapper. Getting the following error
Steps to reproduce
make
Environment
Ubuntu 18.04
gtsam 4.1.1
MATLAB 2018a
Python 3.8.12 (conda env)
Additional information
I am able to build the python wrapper just fine
The text was updated successfully, but these errors were encountered: