Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Matlab wrapper import issue #149

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Fix Matlab wrapper import issue #149

merged 2 commits into from
Jul 4, 2022

Conversation

varunagrawal
Copy link
Collaborator

This PR fixes borglab/gtsam#1118

@varunagrawal varunagrawal requested a review from gchenfc July 3, 2022 23:51
@varunagrawal varunagrawal self-assigned this Jul 3, 2022
@varunagrawal varunagrawal requested a review from ProfFan July 3, 2022 23:52
@varunagrawal varunagrawal changed the title Install the python package explicitly Fix Matlab wrapper import issue Jul 4, 2022
mattking-smith
mattking-smith approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@mattking-smith mattking-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit ca357cc into master Jul 4, 2022
@varunagrawal varunagrawal deleted the install-package branch July 4, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattking-smith mattking-smith mattking-smith approved these changes

@gchenfc gchenfc Awaiting requested review from gchenfc

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees

@varunagrawal varunagrawal

Labels
bug Something isn't working high-priority quick review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in building MATLAB wrapper: No module named 'gtwrap'
2 participants
@varunagrawal @mattking-smith