Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using system ceres #1259

Closed
Tobias-Fischer opened this issue Jul 31, 2022 · 2 comments
Closed

Allow using system ceres #1259

Tobias-Fischer opened this issue Jul 31, 2022 · 2 comments

Comments

@Tobias-Fischer
Copy link
Contributor

Tobias-Fischer commented Jul 31, 2022

Feature

Currently gtsam always ships its own bundled version of ceres. It would be great if a similar approach as for Eigen or Metis is taken, where alternatively the system version can be used.

Motivation

Bundling ceres is undesirable if package managers like conda-forge are used. Also, most distributions ship ceres themselves, so there should not be a need for the bundled version.

Pitch

Create a cmake/HandleCeres.cmake file that follows the structure of HandleMetis.cmake/HandleEigen.cmake and allows defining GTSAM_USE_SYSTEM_CERES if one wants to use the system ceres.

Alternatives

N/A

Additional context

This relates to our efforts to package gtsam in conda-forge. Currently we patch gtsam to always use the ceres shipped with conda-forge (https://github.com/conda-forge/gtsam-feedstock/blob/main/recipe/unvendor-ceres.patch)

@varunagrawal
Copy link
Collaborator

@Tobias-Fischer I believe this is already tracked in #292? Would you be okay with closing this and updating that issue so we can track all the system libraries together?

@Tobias-Fischer
Copy link
Contributor Author

Indeed this issue already mentions Ceres, so happy to close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants