-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win build + install python bindings on Unix #8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.07.27.20.15.04
Hi @traversaro @wolfv - any clue how to overcome this issue? I think it's something basic but I'm not a Windows expert ..
Note that prior to that:
So the dll gets created but not the lib. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.07.28.08.23.03
Not sure if you solved the problem, but this tipically happens if no symbols are exported. |
I'm trying without Python and without the gtsam-unstable for now just to see if that succeeds. I also limited the number of cores on the win build, as half the time the compiler went out of heap space. |
So it seems like the python buildings on Windows are terribly broken, with
Just the first few lines of errors:
Therefore, I suggest disabling python bindings on Windows for now. We can open an upstream issue to see if they are interested in fixing it? |
I also noticed that previous builds didn't install the python bindings (they were built but not installed). On linux-64 everything builds+installs fine, but on osx something goes wrong with the relocations. The python bindings are looking for the libs in the build folder, which don't exist at test time:
Also see related warnings:
Any ideas how to resolve this @wolfv @traversaro? Weird that it works on linux but not osx. |
I fixed above error by setting CMAKE_SKIP_RPATH=TRUE In this case conda-build is smart enough to do a proper relocation. However this does not happen till the packaging step, so I'm skipping ninja check on osx for now. I think this is ready to go, unless there are any objections? The only missing bit are the windows python bindings - I'll open an upstream issue. I'll also try and get some patches upstreamed. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.07.29.16.12.45
I created some PRs / issues in gtsam upstream: |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)