-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore default for dogleg #9
Comments
dellaert
added a commit
that referenced
this issue
Jun 15, 2019
dellaert
added a commit
that referenced
this issue
Jun 15, 2019
Restored default deltaInit to 1.0 to resolve issue #9
Fixed in pull request #72 |
2 tasks
ProfFan
added a commit
that referenced
this issue
Oct 7, 2020
dfa624e77 Merge pull request #9 from borglab/fix/serialization 7849665a7 Fix serialization git-subtree-dir: wrap git-subtree-split: dfa624e77e24ce3391d23c614d732fc81b4e6193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adam on bitbucket said:
I propose a better value for the initial trust region radius of the DoglegOptimizer, which is defined by DoglegParams.deltaInitial. To close issue #452, it was suggested to change the default value of deltaInitial from 1 to 10. Indeed, that worked for the posted problem, but it appears that deltaInitial is defined in an absolute spatial scale. This new default value of deltaInitial causes a failure of the dogleg optimizer if the scale of the problem is multiplied by 10 (i.e. the vehicles are 6000 units apart instead of 600, they travel 30 units per time step instead of 3, and the standard deviations on distance traveled and inter-vehicle range are set to 0.1 units instead of 0.01)
It seems to me that it would be better to define the deltaInitial relative to the size of the full Gauss-Newton step on the first iteration (which is what I thought it meant when the default was set to 1, which is why I never thought to increase it). As far as I know, it is generally recommended to try the full GN step on the first iteration. However, changing the meaning of this parameter may surprise some folks that have set it manually for their application.
The text was updated successfully, but these errors were encountered: