Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1382 #1383

Closed
wants to merge 1 commit into from
Closed

Fix 1382 #1383

wants to merge 1 commit into from

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jan 11, 2023 •
edited
Loading

Import HybridGaussianFactorGraph instead of forward declaring it.

Fixes #1382

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Jan 11, 2023
@varunagrawal varunagrawal requested a review from dellaert January 11, 2023 19:27
@varunagrawal varunagrawal self-assigned this Jan 11, 2023
@varunagrawal varunagrawal linked an issue Jan 11, 2023 that may be closed by this pull request
Incomplete type 'gtsam::HybridGaussianFactorGraph' #1382
Closed
@dellaert
Copy link
Member

This is not a bug, you need to include it in your file

@varunagrawal
Copy link
Collaborator Author

I did and still get the issue.

@varunagrawal
Copy link
Collaborator Author

I'll try again once I get to a computer. I was pretty confused by this issue myself.

@varunagrawal
Copy link
Collaborator Author

Fix was to include in the .h file (even though the usage is only in the .cpp file).

@dellaert
Copy link
Member

Why close it if it is needed? You were going to try it and determined it is needed, no?

@dellaert dellaert reopened this Jan 13, 2023
@varunagrawal
Copy link
Collaborator Author

@dellaert the issue was that HybridGaussianFactorGraph.h needed to be included in the .h file of my code. I was including it in the .cpp file to avoid polluting the header file (and since HybridGaussianFactorGraph is only used in the .cpp file) but that gave the error in #1382.

Since this is not a bug in GTSAM, I am closing it.

@varunagrawal varunagrawal mentioned this pull request Jan 13, 2023
Closed
@varunagrawal varunagrawal deleted the fix-1382 branch January 28, 2023 21:47
@varunagrawal varunagrawal restored the fix-1382 branch November 27, 2023 20:12
@varunagrawal varunagrawal deleted the fix-1382 branch November 27, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete type 'gtsam::HybridGaussianFactorGraph'
2 participants
@varunagrawal @dellaert