Fix/clang warnings #146
Merged
Fix/clang warnings #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfFan
reviewed
Oct 13, 2019
| Vector diag = cg->R().diagonal(); | ||
| cg->get_model()->whitenInPlace(diag); | ||
| logDet += diag.unaryExpr(ptr_fun<double,double>(log)).sum(); | ||
| logDet += diag.unaryExpr([](double x) { return log(x); }).sum(); |
varunagrawal
added a commit
that referenced
this pull request
Mar 21, 2022
24da9d1be Merge pull request #146 from borglab/fix/matlab 3101236fe fix missing semi-colon for class forward declaration e933e14a0 add missing boost header git-subtree-dir: wrap git-subtree-split: 24da9d1be2b26ecf9abbfd9153b24fbdcf007f4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings on clang. Most are missing overrides from @varunagrawal 's last PR. Probably warnings did not show up on Linux. But I also resolved calls to
ptr_funwhich was deprecated in c++11.This change is