Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust-region doc update #36

Merged
merged 5 commits into from
Jun 1, 2019
Merged

Trust-region doc update #36

merged 5 commits into from
Jun 1, 2019

Conversation

varunagrawal
Copy link
Collaborator

There were some oddities and inconsistencies in the trustregion documents which this PR fixes. I have tried to be as consistent with the notation in Raphael Hauser's lecture notes, upon which this doc is based.

@varunagrawal varunagrawal added the enhancement Improvement to GTSAM label May 31, 2019
@varunagrawal varunagrawal requested a review from dellaert May 31, 2019 15:49
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you re-render a pdf? I can't see whether you fixed those uu thingies etc... I think they should be replaced with propoer math.

doc/trustregion.bib Outdated Show resolved Hide resolved
@varunagrawal
Copy link
Collaborator Author

I did re-render the PDF.

@dellaert dellaert merged commit e439629 into develop Jun 1, 2019
@dellaert dellaert deleted the feature/trustregion-doc branch June 1, 2019 19:50
varunagrawal added a commit that referenced this pull request Mar 14, 2021
d19cda546 Merge pull request #36 from borglab/fix/shared-ptr-property
13ef2485c Merge pull request #37 from borglab/feature/multiple-templates
f3f40b375 add support for multiple instantiated templates
4f33353ef support for templated return types
1244045c2 cleaned up tests and added test for Pybind property shared pointer
0f3fbc428 add support for pointers as properties, and update docs
9974a73ec Merge pull request #35 from borglab/feature/docs
e9c52421d Added DOCS with info about wrapping structure
627154f9f fix call to superclass init
8a4e61ead added more docs and fixed typo for holder_type
b1bdec933 added docstrings to interface_parser and took care of all the errors and warnings

git-subtree-dir: wrap
git-subtree-split: d19cda5467f8b5cb8d4f571d8735ede328dae02d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to GTSAM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants