Code

Fix/plane factor#564

Code

Merged

dellaert merged 36 commits intodevelopborglab/gtsam:developfrom fix/planeFactorborglab/gtsam:fix/planeFactorCopy head branch name to clipboardFeb 23, 2021

+669-217

Commits

Commits on Jun 16, 2020

• Add unit test for oriented plane 3 factor jacobian

  dwisth

  committed
  df5ecac

  Copy full SHA for df5ecac

Commits on Jun 22, 2020

• Fix OrientedPlane3Factor jacobian using numericalDerivative

  dwisth

  committed
  75eb859

  Copy full SHA for 75eb859

Commits on Jun 23, 2020

• Address Frank's comments and clean up changes

  dwisth

  committed
  58a0f82

  Copy full SHA for 58a0f82

• Update style and switch to errorVector()

  dwisth

  committed
  795380d

  Copy full SHA for 795380d

Commits on Jul 15, 2020

• Fix all unit tests. Only remaining item is the analytical Jacobian for Unit3::localCoordinates.

  dwisth

  committed
  a897ee7

  Copy full SHA for a897ee7

Commits on Oct 12, 2020

• Fixed some warnings

  dellaert

  committed
  1708162

  Copy full SHA for 1708162

• Printing now transpose

  dellaert

  committed
  5df3eeb

  Copy full SHA for 5df3eeb

• Simplified evaluateError

  dellaert

  committed
  4adca52

  Copy full SHA for 4adca52

• Use keyFormatter

  dellaert

  committed
  6909c2b

  Copy full SHA for 6909c2b

• Added unit test for issue 561

  dellaert

  committed
  adbd9a6

  Copy full SHA for adbd9a6

Commits on Nov 15, 2020

• pass in params to optimizer

  varunagrawal

  committed
  af4005a

  Copy full SHA for af4005a

Commits on Nov 16, 2020

• Merge branch 'develop' into fix/planeFactor

  varunagrawal

  committed
  d4aec50

  Copy full SHA for d4aec50

Commits on Dec 6, 2020

• Merge branch 'develop' into fix/oriented-plane3-factor-jacobian

  varunagrawal

  committed
  edb3aea

  Copy full SHA for edb3aea

• formatting and small fixes

  varunagrawal

  committed
  534fa6b

  Copy full SHA for 534fa6b

Commits on Jan 19, 2021

• Add a simplifed version of the minimal failing example

  dwisth

  committed
  5076837

  Copy full SHA for 5076837

• Add hessian calculation

  dwisth

  committed
  62119d8

  Copy full SHA for 62119d8

Commits on Jan 21, 2021

• Merge pull request #680 from dwisth/fix/planeFactor-dwisth

  Show description for b9a8101
  dellaert

  authored
  b9a8101

  Copy full SHA for b9a8101

• Merge branch 'develop' into fix/planeFactor

  dellaert

  committed
  b5789f6

  Copy full SHA for b5789f6

• use transform rather than deprecated static function

  dellaert

  committed
  6b11c9f

  Copy full SHA for 6b11c9f

• Merge branch 'fix/planeFactor' into fix/oriented-plane3-factor-jacobian

  dellaert

  authored
  fd8575b

  Copy full SHA for fd8575b

• Merge pull request #362 from dwisth/fix/oriented-plane3-factor-jacobian

  Show description for 564c8bf
  dellaert

  authored
  564c8bf

  Copy full SHA for 564c8bf

• Got rid of extra keys

  dellaert

  committed
  68887f2

  Copy full SHA for 68887f2

• Got rid of static versions of methods

  dellaert

  committed
  6c39730

  Copy full SHA for 6c39730

• Cleaned up derivative code

  dellaert

  committed
  1b36c74

  Copy full SHA for 1b36c74

• Cleanup

  dellaert

  committed
  79d4247

  Copy full SHA for 79d4247

Commits on Jan 29, 2021

• cleanup

  dellaert

  committed
  46464aa

  Copy full SHA for 46464aa

Commits on Feb 3, 2021

• Comments

  dellaert

  committed
  9eb6267

  Copy full SHA for 9eb6267

Commits on Feb 15, 2021

• Add new oriented plane 3 factors with local linearisation point

  dwisth

  committed
  a62bdd4

  Copy full SHA for a62bdd4

• Update print method of OrientedPlane3Factor

  dwisth

  committed
  0ad488c

  Copy full SHA for 0ad488c

• remove deprecated Unit3::error() which is replaced by Unit3::errorVector()

  dwisth

  committed
  5087d36

  Copy full SHA for 5087d36

• Update documentation on new factor

  dwisth

  committed
  7480d14

  Copy full SHA for 7480d14

Commits on Feb 16, 2021

• Revert "remove deprecated Unit3::error() which is replaced by Unit3::errorVector()"

  Show description for 1771a56
  dwisth

  committed
  1771a56

  Copy full SHA for 1771a56

• remove the error() function from OrientedPlane3 (it had incorrect derivatives)

  dwisth

  committed
  71f39ab

  Copy full SHA for 71f39ab

• Tidy up comments and use cpplint

  dwisth

  committed
  960a3e1

  Copy full SHA for 960a3e1

• small tidy and fix unit tests

  dwisth

  committed
  5b0bd08

  Copy full SHA for 5b0bd08

Commits on Feb 20, 2021

• Add inline comments on commented-out unit tests

  dwisth

  committed
  8f18ce9

  Copy full SHA for 8f18ce9