Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline keyword for navigation expression functions #60

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

varunagrawal
Copy link
Collaborator

Adds inline keyword to functions introduced in PR #32 to avoid multiple declaration conflicts during linking as well as keep all declarations in the file consistent.

@varunagrawal varunagrawal requested a review from dellaert June 11, 2019 22:11
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks !!!

@dellaert dellaert merged commit 8e13655 into develop Jun 11, 2019
@dellaert dellaert deleted the feature/inline-navigation-expressions branch June 11, 2019 23:50
varunagrawal pushed a commit that referenced this pull request Mar 25, 2021
9a467794e Merge pull request #61 from borglab/fix/python-variables
6bae7af99 added more status messages and set the PYBIND11_PYTHON_VERSION each time
5129cf3b9 set both sets of Python variables and find python version when including PybindWrap
5a67b526c Merge pull request #60 from borglab/fix/multi-template-methods
4a73b29ef better method names for testing templated methods
989fdf946 added unit test for multi-template methods
a56908c21 add namespace qualification to instantiations
a25d9631e graceful handling of templated method instantiations
0baa5ab5d multiple templates in methods

git-subtree-dir: wrap
git-subtree-split: 9a467794e8542872b2782cdaec338aaa30a92e33
varunagrawal pushed a commit that referenced this pull request Mar 25, 2021
9a467794e Merge pull request #61 from borglab/fix/python-variables
6bae7af99 added more status messages and set the PYBIND11_PYTHON_VERSION each time
5129cf3b9 set both sets of Python variables and find python version when including PybindWrap
5a67b526c Merge pull request #60 from borglab/fix/multi-template-methods
4a73b29ef better method names for testing templated methods
989fdf946 added unit test for multi-template methods
a56908c21 add namespace qualification to instantiations
a25d9631e graceful handling of templated method instantiations
0baa5ab5d multiple templates in methods

git-subtree-dir: wrap
git-subtree-split: 9a467794e8542872b2782cdaec338aaa30a92e33
varunagrawal added a commit that referenced this pull request Mar 25, 2021
9a467794e Merge pull request #61 from borglab/fix/python-variables
6bae7af99 added more status messages and set the PYBIND11_PYTHON_VERSION each time
5129cf3b9 set both sets of Python variables and find python version when including PybindWrap
5a67b526c Merge pull request #60 from borglab/fix/multi-template-methods
4a73b29ef better method names for testing templated methods
989fdf946 added unit test for multi-template methods
a56908c21 add namespace qualification to instantiations
a25d9631e graceful handling of templated method instantiations
0baa5ab5d multiple templates in methods

git-subtree-dir: wrap
git-subtree-split: 9a467794e8542872b2782cdaec338aaa30a92e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants