Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GTSAM_EXPORT #670

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Fix GTSAM_EXPORT #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347ea5d
Fix GTSAM_EXPORT for some classes and function
RamadanAhmed Jan 14, 2021
15a8f41
Merge branch 'develop' of https://github.com/borglab/gtsam into develop
RamadanAhmed Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gtsam/geometry/Point3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ GTSAM_EXPORT double dot(const Point3& p, const Point3& q,

/// mean
template <class CONTAINER>
GTSAM_EXPORT Point3 mean(const CONTAINER& points) {
Point3 mean(const CONTAINER& points) {
if (points.size() == 0) throw std::invalid_argument("Point3::mean input container is empty");
Point3 sum(0, 0, 0);
sum = std::accumulate(points.begin(), points.end(), sum);
Expand Down
4 changes: 2 additions & 2 deletions gtsam/sfm/ShonanAveraging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,15 +414,15 @@ class GTSAM_EXPORT ShonanAveraging {
// Subclasses for d=2 and d=3 that explicitly instantiate, as well as provide a
// convenience interface with file access.

class ShonanAveraging2 : public ShonanAveraging<2> {
class GTSAM_EXPORT ShonanAveraging2 : public ShonanAveraging<2> {
public:
ShonanAveraging2(const Measurements &measurements,
const Parameters &parameters = Parameters());
explicit ShonanAveraging2(std::string g2oFile,
const Parameters &parameters = Parameters());
};

class ShonanAveraging3 : public ShonanAveraging<3> {
class GTSAM_EXPORT ShonanAveraging3 : public ShonanAveraging<3> {
public:
ShonanAveraging3(const Measurements &measurements,
const Parameters &parameters = Parameters());
Expand Down